Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multiple): miscellanous fixes/enhancements #1614

Merged
merged 2 commits into from Nov 3, 2022

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Nov 1, 2022

  • update commit-triggered CI to run on any branch starting with prefix ci-diagnose*
  • fix Python usage in cross-platform CI jobs
  • fix default values for hnoflo and hdry introduced in update(plotting): added default masked values  #1610
    • correct hdry default from -1e-30 to -1e30
    • add defaults to BaseModel (fix notebook errors caused by None passed to numpy)
    • this caused the MODFLOW 6 nightly build to fail — maybe worth switching that repo's dependency to FloPy master branch or a published release so issues that get past this repo's develop CI don't break the nightly distribution?

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #1614 (4500ff1) into develop (5a9bec2) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           develop   #1614     +/-   ##
=========================================
- Coverage     72.7%   72.7%   -0.1%     
=========================================
  Files          251     251             
  Lines        54501   54501             
=========================================
- Hits         39671   39665      -6     
- Misses       14830   14836      +6     
Impacted Files Coverage Δ
flopy/mbase.py 69.2% <100.0%> (ø)
flopy/plot/crosssection.py 66.4% <100.0%> (ø)
flopy/plot/map.py 84.2% <100.0%> (ø)
flopy/utils/get_modflow.py 64.0% <0.0%> (-1.5%) ⬇️

@wpbonelli wpbonelli marked this pull request as ready for review November 3, 2022 14:22
@jdhughes-usgs jdhughes-usgs merged commit e20ea05 into modflowpy:develop Nov 3, 2022
wpbonelli added a commit to wpbonelli/flopy that referenced this pull request Dec 14, 2022
* fix(ci/defaults): fix CI config and hnoflo/hdry default values
* fix(ci): use bash -l {0} with micromamba, otherwise bash
wpbonelli added a commit to wpbonelli/flopy that referenced this pull request Dec 14, 2022
* fix(ci/defaults): fix CI config and hnoflo/hdry default values
* fix(ci): use bash -l {0} with micromamba, otherwise bash
wpbonelli added a commit that referenced this pull request Dec 14, 2022
* fix(ci/defaults): fix CI config and hnoflo/hdry default values
* fix(ci): use bash -l {0} with micromamba, otherwise bash
wpbonelli added a commit to wpbonelli/flopy that referenced this pull request Dec 14, 2022
* fix(ci/defaults): fix CI config and hnoflo/hdry default values
* fix(ci): use bash -l {0} with micromamba, otherwise bash
@wpbonelli wpbonelli deleted the ci-diagnose-pip-mac branch December 19, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants