fixBug: not reading comma separated data correctly #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To test: ```python from flopy.utils.datautil import PyListUtil line = '13,14' ``` PyListUtil.split_data_line(line)
Codecov Report
@@ Coverage Diff @@
## develop #1634 +/- ##
=======================================
Coverage 72.8% 72.8%
=======================================
Files 251 251
Lines 54502 54503 +1
=======================================
+ Hits 39697 39698 +1
Misses 14805 14805
|
|
@ougx thanks for catching this. The original CI failure was unrelated to your fix. |
|
Great. Thanks for fixing it @w-bonelli |
jdhughes-usgs
approved these changes
Nov 23, 2022
wpbonelli
added a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
* fixBug: not reading comma separated data correctly To test: ```python from flopy.utils.datautil import PyListUtil line = '13,14' ``` PyListUtil.split_data_line(line) * test(PyListUtil): add minimal test for split_data_line() Co-authored-by: w-bonelli <wesbonelli@gmail.com>
wpbonelli
added a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
* fixBug: not reading comma separated data correctly To test: ```python from flopy.utils.datautil import PyListUtil line = '13,14' ``` PyListUtil.split_data_line(line) * test(PyListUtil): add minimal test for split_data_line() Co-authored-by: w-bonelli <wesbonelli@gmail.com>
wpbonelli
added a commit
that referenced
this pull request
Dec 14, 2022
* fixBug: not reading comma separated data correctly To test: ```python from flopy.utils.datautil import PyListUtil line = '13,14' ``` PyListUtil.split_data_line(line) * test(PyListUtil): add minimal test for split_data_line() Co-authored-by: w-bonelli <wesbonelli@gmail.com>
wpbonelli
added a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
* fixBug: not reading comma separated data correctly To test: ```python from flopy.utils.datautil import PyListUtil line = '13,14' ``` PyListUtil.split_data_line(line) * test(PyListUtil): add minimal test for split_data_line() Co-authored-by: w-bonelli <wesbonelli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test:
PyListUtil.split_data_line(line)