Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(get-modflow): accommodate mf6 release asset name change #1855

Merged
merged 2 commits into from Jun 29, 2023

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Jun 29, 2023

The mf6 windows distribution has an OS tag win64 now so can be handled in the same way as the nightly build and executables dists — all three now have assets with linux, mac, and win64 in the name

Fixes get-modflow <bindir> --repo modflow6, which could break if used with the latest release

@wpbonelli wpbonelli marked this pull request as ready for review June 29, 2023 05:56
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #1855 (273b5dd) into develop (4f63366) will decrease coverage by 0.1%.
The diff coverage is 75.0%.

@@            Coverage Diff            @@
##           develop   #1855     +/-   ##
=========================================
- Coverage     72.3%   72.3%   -0.1%     
=========================================
  Files          256     256             
  Lines        56114   56112      -2     
=========================================
- Hits         40577   40575      -2     
  Misses       15537   15537             
Impacted Files Coverage Δ
flopy/utils/get_modflow.py 63.9% <75.0%> (-0.2%) ⬇️

@wpbonelli wpbonelli merged commit b8dffbc into modflowpy:develop Jun 29, 2023
21 checks passed
@wpbonelli wpbonelli deleted the fix-get-modflow branch June 29, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant