Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(expired deprecation): remove warning for third parameter of Grid.intersect #1883

Merged
merged 1 commit into from Aug 1, 2023

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Jul 27, 2023

This warning was introduced with #1326 for FloPy 3.3.5, changed to an error with #1489 for FloPy 3.3.6.

This error was intended to be removed for 3.3.7, so this is overdue.

@mwtoews mwtoews added this to the 3.5.0 milestone Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #1883 (b0fdb11) into develop (8c330a7) will increase coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #1883   +/-   ##
=======================================
  Coverage     72.2%   72.2%           
=======================================
  Files          257     257           
  Lines        56414   56398   -16     
=======================================
- Hits         40751   40744    -7     
+ Misses       15663   15654    -9     
Files Changed Coverage Δ
flopy/discretization/grid.py 74.9% <ø> (+0.3%) ⬆️
flopy/discretization/structuredgrid.py 46.9% <ø> (-0.1%) ⬇️
flopy/discretization/unstructuredgrid.py 84.9% <ø> (+0.3%) ⬆️
flopy/discretization/vertexgrid.py 83.1% <ø> (+0.4%) ⬆️

@wpbonelli wpbonelli merged commit 70b9a37 into modflowpy:develop Aug 1, 2023
21 checks passed
@mwtoews mwtoews deleted the rm-warn_intersect branch August 2, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants