Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(vtk): remove deprecated export_* functions #1890

Merged
merged 2 commits into from Aug 3, 2023

Conversation

wpbonelli
Copy link
Contributor

  • deprecated in 3.3.5 (March 2022)
  • update docstrings which previously referred to these methods, refer now to Vtk class

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #1890 (966f26c) into develop (70b9a37) will increase coverage by 0.1%.
Report is 5 commits behind head on develop.
The diff coverage is n/a.

❗ Current head 966f26c differs from pull request most recent head f3cf448. Consider uploading reports for the commit f3cf448 to get more accurate results

@@            Coverage Diff            @@
##           develop   #1890     +/-   ##
=========================================
+ Coverage     72.2%   72.4%   +0.1%     
=========================================
  Files          257     257             
  Lines        56488   56373    -115     
=========================================
- Hits         40836   40829      -7     
+ Misses       15652   15544    -108     
Files Changed Coverage Δ
flopy/export/utils.py 64.7% <ø> (-0.1%) ⬇️
flopy/export/vtk.py 79.8% <ø> (+9.5%) ⬆️
flopy/mf6/mfmodel.py 58.7% <ø> (ø)

@wpbonelli wpbonelli marked this pull request as ready for review August 1, 2023 19:32
Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should "Vtk ctor" be "Vtk actor"?

@wpbonelli
Copy link
Contributor Author

thanks @langevin-usgs updated to initializer, as ctor (constructor) was improper use per python conventions anyway

@wpbonelli wpbonelli merged commit ca838b1 into modflowpy:develop Aug 3, 2023
2 of 10 checks passed
@wpbonelli wpbonelli deleted the deprecate-vtk-export-fns branch August 3, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants