Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mfsimlist): add functionality to parse memory_print_options #2009

Merged
merged 5 commits into from Nov 22, 2023

Conversation

jdhughes-usgs
Copy link
Contributor

  • add function to return memory summary information as a dictionary

* add function to return memory summary information as a dictionary
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Merging #2009 (ea70772) into develop (7cc5e6f) will increase coverage by 0.0%.
Report is 4 commits behind head on develop.
The diff coverage is 95.3%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #2009    +/-   ##
========================================
  Coverage     72.7%   72.8%            
========================================
  Files          259     259            
  Lines        58956   59111   +155     
========================================
+ Hits         42916   43066   +150     
- Misses       16040   16045     +5     
Files Coverage Δ
flopy/mf6/utils/mfsimlistfile.py 95.6% <95.3%> (+3.8%) ⬆️

... and 18 files with indirect coverage changes

Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. My only thought is that if you wanted, you could check mfsim.lst to see what memory print option was specified. The block looks like the following.

 READING SIMULATION OPTIONS
    MAXIMUM NUMBER OF ERRORS THAT WILL BE STORED IS 1000
    MEMORY_PRINT_OPTION SET TO "ALL".
 END OF SIMULATION OPTIONS

Might be able to check for the memory print option in init and issue a subsequent warning if user attempts to access memory information that is not present. Maybe a feature to add later.

@jdhughes-usgs
Copy link
Contributor Author

Looks nice. My only thought is that if you wanted, you could check mfsim.lst to see what memory print option was specified. The block looks like the following.

 READING SIMULATION OPTIONS
    MAXIMUM NUMBER OF ERRORS THAT WILL BE STORED IS 1000
    MEMORY_PRINT_OPTION SET TO "ALL".
 END OF SIMULATION OPTIONS

Might be able to check for the memory print option in init and issue a subsequent warning if user attempts to access memory information that is not present. Maybe a feature to add later.

Added in __init__ and added warnings if information is not available

@jdhughes-usgs jdhughes-usgs merged commit 121ca78 into modflowpy:develop Nov 22, 2023
24 checks passed
@jdhughes-usgs jdhughes-usgs deleted the mfsimlst-memory branch November 24, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants