Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(contour_array): add tri_mask kwarg to parameters #2078

Merged
merged 9 commits into from Feb 1, 2024

Conversation

jlarsen-usgs
Copy link
Contributor

@jlarsen-usgs jlarsen-usgs commented Jan 31, 2024

  • update docstrings for tri_mask kwarg
  • re-lint flopy with new version of black (previously 23.3, now 24.1)
  • update pyproject.toml, set pytest < 8.0.0

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f8eac0f) 73.0% compared to head (688a10f) 73.0%.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #2078   +/-   ##
=======================================
  Coverage     73.0%   73.0%           
=======================================
  Files          259     259           
  Lines        59330   59329    -1     
=======================================
  Hits         43332   43332           
+ Misses       15998   15997    -1     
Files Coverage Δ
flopy/__init__.py 100.0% <ø> (ø)
flopy/export/netcdf.py 49.2% <100.0%> (ø)
flopy/export/shapefile_utils.py 83.7% <ø> (ø)
flopy/mbase.py 69.9% <ø> (ø)
flopy/mf6/data/mfdatastorage.py 71.4% <100.0%> (ø)
flopy/mf6/data/mffileaccess.py 71.3% <100.0%> (ø)
flopy/mf6/mfbase.py 81.8% <ø> (ø)
flopy/mf6/mfpackage.py 69.6% <100.0%> (ø)
flopy/mf6/utils/createpackages.py 6.6% <ø> (ø)
flopy/mf6/utils/model_splitter.py 70.0% <100.0%> (ø)
... and 70 more

... and 1 file with indirect coverage changes

@@ -52,7 +52,7 @@ test = [
"jupyter",
"jupytext",
"modflow-devtools",
"pytest",
"pytest < 8.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should no longer be necessary after #2077 but fine for now

@wpbonelli wpbonelli merged commit 92853a9 into modflowpy:develop Feb 1, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants