Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tutorial, verbosity setter): fixed tutorial model name and verbosity setter (#2182) #2193

Merged
merged 1 commit into from
May 21, 2024

Conversation

scottrp
Copy link
Contributor

@scottrp scottrp commented May 21, 2024

Tutorial01's name was too long for MODFLOW. Additionally, it did not define a top and botm.

Added a verbosity setter that automatically converts numerical verbosity values to the verbosity enumeration value, so that interval values are kept consistent.

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 70.1%. Comparing base (029a4e1) to head (aa05503).
Report is 20 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2193     +/-   ##
=========================================
+ Coverage     68.3%   70.1%   +1.7%     
=========================================
  Files          260     261      +1     
  Lines        57947   58232    +285     
=========================================
+ Hits         39611   40829   +1218     
+ Misses       18336   17403    -933     
Files Coverage Δ
flopy/mf6/mfsimbase.py 61.8% <80.0%> (-0.7%) ⬇️

... and 179 files with indirect coverage changes

@spaulins-usgs spaulins-usgs merged commit 7879c2f into modflowpy:develop May 21, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants