FIX-#31: Fix test_nans and add mixed sort test #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valerieyip
force-pushed
the
mixed_sort_test
branch
from
dc5da4f
to
0308eff
Compare
richardlin047
requested changes
Mar 24, 2021
richardlin047
approved these changes
Apr 7, 2021
There was a problem hiding this comment.
@valerieyip LGTM, just need to rebase master and fix the conflict in modin_spreadsheet/tests/test_grid.py
…d data columns and row values Signed-off-by: Valerie Yip <valerieyip@berkeley.edu>
…readability Signed-off-by: Valerie Yip <valerieyip@berkeley.edu>
valerieyip
force-pushed
the
mixed_sort_test
branch
from
d2a53d3
to
9df3aef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #31 test_nans was not working because the column name was an integer and grid.py concatenates a string to column names to ensure unique column names. Fix by casting to string.
Added a test_mixed_type_sort with mixed data types such as np.nan as well as sorting a column with an integer column name.