Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-#22: Redo README and docs for modin-spreadsheet #36

Merged
merged 16 commits into from
Mar 31, 2021

Conversation

richardlin047
Copy link
Collaborator

@richardlin047 richardlin047 commented Mar 26, 2021

Remove most Qgrid content and rewrite content for modin-spreadsheet so it's presentable for new users.

  • Replaces main demo with new one including history
  • Still relies on some Qgrid documentation and demos
  • Removes mentions of support for JupyterLab
  • Removes readthedocs build

Documentation still needs for future PR:

  • Live demo notebook for public i.e. binder
  • In-depth descriptions of core functionality

Signed-off-by: Richard Lin <richard.lin.047@berkeley.edu>
Signed-off-by: Richard Lin <richard.lin.047@berkeley.edu>
Signed-off-by: Richard Lin <richard.lin.047@berkeley.edu>
Signed-off-by: Richard Lin <richard.lin.047@berkeley.edu>
Signed-off-by: Richard Lin <richard.lin.047@berkeley.edu>
Signed-off-by: Richard Lin <richard.lin.047@berkeley.edu>
Signed-off-by: Richard Lin <richard.lin.047@berkeley.edu>
Signed-off-by: Richard Lin <richard.lin.047@berkeley.edu>
Signed-off-by: Richard Lin <richard.lin.047@berkeley.edu>
Signed-off-by: Richard Lin <richard.lin.047@berkeley.edu>
Signed-off-by: Richard Lin <richard.lin.047@berkeley.edu>
Signed-off-by: Richard Lin <richard.lin.047@berkeley.edu>
Signed-off-by: Richard Lin <richard.lin.047@berkeley.edu>
Signed-off-by: Richard Lin <richard.lin.047@berkeley.edu>
Signed-off-by: Richard Lin <richard.lin.047@berkeley.edu>
Signed-off-by: Richard Lin <richard.lin.047@berkeley.edu>
@richardlin047 richardlin047 marked this pull request as ready for review March 27, 2021 23:19
Copy link
Collaborator

@devin-petersohn devin-petersohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardlin047 Looks great, should we also change the repo name to modin-spreadsheet?

@richardlin047
Copy link
Collaborator Author

@richardlin047 Looks great, should we also change the repo name to modin-spreadsheet?

Yes, I can do that and also make any changes to the docs as needed in this PR.

@devin-petersohn devin-petersohn merged commit 2148344 into modin-project:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants