Skip to content

Commit

Permalink
Defaulting to Pandas for Not Implemented DataFrame Functions (#138)
Browse files Browse the repository at this point in the history
* changing NotImplementedError text

* Defaulting to Pandas Implementation for functions not yet implemented

* missing commas

* formatting changes

* adding pandas functions instead of strings for function names

* skipping default pandas tests

* more test skipping and formatting

* Fix formatting

* skipping one more test

* fix return type from defaulting to pandas function

* updating to_pandas function for other arg
  • Loading branch information
osalpekar authored and devin-petersohn committed Oct 9, 2018
1 parent 520ebab commit 00ee9e4
Show file tree
Hide file tree
Showing 8 changed files with 498 additions and 439 deletions.
2 changes: 1 addition & 1 deletion docs/pandas_on_ray.rst
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ following:

.. code-block:: text
NotImplementedError: To contribute to Pandas on Ray, please visit github.com/modin-project/modin.
NotImplementedError: To contribute to Modin, please visit github.com/modin-project/modin.
We have compiled a list of currently supported methods `here`_.

Expand Down
2 changes: 1 addition & 1 deletion modin/pandas/concat.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def concat(
if isinstance(objs, dict):
raise NotImplementedError(
"Obj as dicts not implemented. To contribute to "
"Pandas on Ray, please visit github.com/ray-project/ray."
"Modin, please visit github.com/ray-project/ray."
)
axis = pandas.DataFrame()._get_axis_number(axis)

Expand Down

0 comments on commit 00ee9e4

Please sign in to comment.