Skip to content

Commit

Permalink
FIX-#3896: Change Series.values to default to to_numpy(). (#3979)
Browse files Browse the repository at this point in the history
Signed-off-by: jeffreykennethli <jkli@ponder.io>
  • Loading branch information
jeffreykennethli committed Jan 23, 2022
1 parent aa54a0b commit 67228ef
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
2 changes: 1 addition & 1 deletion modin/pandas/series.py
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ def values(self): # noqa: RT01, D200
"""
Return Series as ndarray or ndarray-like depending on the dtype.
"""
return super(Series, self).to_numpy().flatten()
return self.to_numpy()

def add(self, other, level=None, fill_value=None, axis=0): # noqa: PR01, RT01, D200
"""
Expand Down
15 changes: 15 additions & 0 deletions modin/pandas/test/test_series.py
Original file line number Diff line number Diff line change
Expand Up @@ -3213,6 +3213,21 @@ def test_to_period():
)
def test_to_numpy(data):
modin_series, pandas_series = create_test_series(data)
assert_array_equal(modin_series.to_numpy(), pandas_series.to_numpy())


@pytest.mark.parametrize(
"data",
test_data_values + test_data_large_categorical_series_values,
ids=test_data_keys + test_data_large_categorical_series_keys,
)
def test_series_values(data):
modin_series, pandas_series = create_test_series(data)
assert_array_equal(modin_series.values, pandas_series.values)


def test_series_empty_values():
modin_series, pandas_series = pd.Series(), pandas.Series()
assert_array_equal(modin_series.values, pandas_series.values)


Expand Down

0 comments on commit 67228ef

Please sign in to comment.