Skip to content

Commit

Permalink
Refactor the QueryCompiler module to separate backends (#510)
Browse files Browse the repository at this point in the history
* Refactor the QueryCompiler module to separate backends

* Preparing to factor out Metadata management into a separate class
* Create `modin.backends.<base, pandas, pyarrow>

* Fix path to pyarrow coverage
  • Loading branch information
devin-petersohn committed Mar 24, 2019
1 parent 33a8631 commit 8e69509
Show file tree
Hide file tree
Showing 15 changed files with 10 additions and 21 deletions.
2 changes: 1 addition & 1 deletion .coveragerc
Expand Up @@ -15,7 +15,7 @@ omit =
modin/engines/dask/*
# Skip Gandiva because it is experimental
modin/experimental/engines/pyarrow_on_ray/*
modin/data_management/query_compiler/pyarrow_query_compiler.py
modin/backends/pyarrow/*

[report]
exclude_lines =
Expand Down
Empty file added modin/backends/__init__.py
Empty file.
Empty file added modin/backends/base/__init__.py
Empty file.
File renamed without changes.
Empty file.
Expand Up @@ -18,7 +18,7 @@

from modin.engines.base.frame.partition_manager import BaseFrameManager
from modin.error_message import ErrorMessage
from .base_query_compiler import BaseQueryCompiler
from modin.backends.base.query_compiler import BaseQueryCompiler


class PandasQueryCompiler(BaseQueryCompiler):
Expand Down
Empty file.
@@ -1,4 +1,4 @@
from .pandas_query_compiler import PandasQueryCompiler
from modin.backends.pandas.query_compiler import PandasQueryCompiler
import pyarrow as pa
import pandas
from pandas.core.computation.expr import Expr
Expand Down
4 changes: 2 additions & 2 deletions modin/data_management/factories.py
Expand Up @@ -8,7 +8,7 @@

from modin import __execution_engine__ as execution_engine
from modin import __partition_format__ as partition_format
from .query_compiler import PandasQueryCompiler
from modin.backends.pandas.query_compiler import PandasQueryCompiler


class BaseFactory(object):
Expand Down Expand Up @@ -298,7 +298,7 @@ class ExperimentalPyarrowOnRayFactory(BaseFactory): # pragma: no cover
PyarrowOnRayFrameManager,
)
from modin.experimental.engines.pyarrow_on_ray.io import PyarrowOnRayIO
from modin.data_management.query_compiler import PyarrowQueryCompiler
from modin.backends.pyarrow.query_compiler import PyarrowQueryCompiler

query_compiler_cls = PyarrowQueryCompiler
block_partitions_cls = PyarrowOnRayFrameManager
Expand Down
11 changes: 0 additions & 11 deletions modin/data_management/query_compiler/__init__.py

This file was deleted.

2 changes: 1 addition & 1 deletion modin/engines/base/io.py
Expand Up @@ -4,7 +4,7 @@

import pandas
from modin.error_message import ErrorMessage
from modin.data_management.query_compiler import BaseQueryCompiler
from modin.backends.base.query_compiler import BaseQueryCompiler


class BaseIO(object):
Expand Down
2 changes: 1 addition & 1 deletion modin/engines/dask/pandas_on_dask_delayed/io.py
Expand Up @@ -3,7 +3,7 @@
from __future__ import print_function

from modin.engines.base.io import BaseIO
from modin.data_management.query_compiler import PandasQueryCompiler
from modin.backends.pandas.query_compiler import PandasQueryCompiler
from modin.engines.dask.pandas_on_dask_delayed.frame.partition_manager import (
DaskFrameManager,
)
Expand Down
2 changes: 1 addition & 1 deletion modin/engines/python/pandas_on_python/io.py
Expand Up @@ -3,7 +3,7 @@
from __future__ import print_function

from modin.engines.base.io import BaseIO
from modin.data_management.query_compiler import PandasQueryCompiler
from modin.backends.pandas.query_compiler import PandasQueryCompiler
from modin.engines.python.pandas_on_python.frame.partition_manager import (
PythonFrameManager,
)
Expand Down
2 changes: 1 addition & 1 deletion modin/engines/ray/pandas_on_ray/io.py
Expand Up @@ -7,7 +7,7 @@
from io import BytesIO
import ray
from modin.data_management.utils import split_result_of_axis_func_pandas
from modin.data_management.query_compiler import PandasQueryCompiler
from modin.backends.pandas.query_compiler import PandasQueryCompiler
from modin.engines.ray.generic.io import RayIO
from modin.engines.ray.pandas_on_ray.frame.partition_manager import (
PandasOnRayFrameManager,
Expand Down
2 changes: 1 addition & 1 deletion modin/experimental/engines/pyarrow_on_ray/io.py
@@ -1,4 +1,4 @@
from modin.data_management.query_compiler import PyarrowQueryCompiler
from modin.backends.pyarrow.query_compiler import PyarrowQueryCompiler
from modin.engines.ray.generic.io import RayIO
from modin.experimental.engines.pyarrow_on_ray.frame.partition_manager import (
PyarrowOnRayFrameManager,
Expand Down

0 comments on commit 8e69509

Please sign in to comment.