Skip to content

Commit

Permalink
Fix omnisci and MODI_ENGINE=PYTHON.
Browse files Browse the repository at this point in the history
Signed-off-by: mvashishtha <mahesh@ponder.io>
  • Loading branch information
mvashishtha committed Oct 7, 2022
1 parent b7b3fe0 commit ab2ebd7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 0 additions & 2 deletions modin/_compat/core/latest/base_io.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ def read_csv(
usecols=None,
squeeze=False,
prefix=lib.no_default,
mangle_dupe_cols=True,
dtype=None,
engine=None,
converters=None,
Expand Down Expand Up @@ -126,7 +125,6 @@ def read_csv(
usecols=usecols,
squeeze=squeeze,
prefix=prefix,
mangle_dupe_cols=mangle_dupe_cols,
dtype=dtype,
engine=engine,
converters=converters,
Expand Down
8 changes: 5 additions & 3 deletions modin/pandas/test/test_io.py
Original file line number Diff line number Diff line change
Expand Up @@ -513,12 +513,14 @@ def test_read_csv_mangle_dupe_cols(self):
@pytest.mark.filterwarnings(
"error:.*'mangle_dupe_cols' keyword is deprecated:FutureWarning"
)
@pytest.mark.xfail(
StorageFormat.get() == "Hdk",
reason="processing of duplicated columns in HDK storage format is not supported yet - issue #3080",
)
def test_read_csv_does_not_warn_mangle_dupe_cols_kwarg(self):
# This test case checks https://github.com/modin-project/modin/issues/5097
with ensure_clean() as unique_filename:
str_non_unique_cols = "col,col,col,col\n5, 6, 7, 8\n9, 10, 11, 12\n"
eval_io_from_str(
str_non_unique_cols,
"a,b,c\n1,2,3\n",
unique_filename,
)

Expand Down

0 comments on commit ab2ebd7

Please sign in to comment.