Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASV] Move logging and caching to the gen_data function #3257

Closed
amyskov opened this issue Jul 20, 2021 · 1 comment · Fixed by #7046
Closed

[ASV] Move logging and caching to the gen_data function #3257

amyskov opened this issue Jul 20, 2021 · 1 comment · Fixed by #7046
Labels
Benchmarking 🏁 Issues and pull requests for evaluating runtime Needs more information ❔ Issues that require more information from the reporter P3 Very minor bugs, or features we can hopefully add some day.

Comments

@amyskov
Copy link
Contributor

amyskov commented Jul 20, 2021

Logging and caching can be moved to the higher level gen_data function from more specific functions like gen_int_data and gen_str_int_data (originated from #2923 (comment)).
@amyskov amyskov added the Benchmarking 🏁 Issues and pull requests for evaluating runtime label Jul 20, 2021
@amyskov amyskov mentioned this issue Jul 20, 2021
Merged
5 tasks
@RehanSD RehanSD added Needs more information ❔ Issues that require more information from the reporter P3 Very minor bugs, or features we can hopefully add some day. labels Oct 12, 2022
@RehanSD
Copy link
Collaborator

RehanSD commented Oct 12, 2022

Hi @amyskov has this issue been resolved?

@arunjose696 arunjose696 mentioned this issue Mar 11, 2024
Merged
7 tasks
anmyachev added a commit that referenced this issue Mar 13, 2024
@arunjose696 @anmyachev
REFACTOR-#3257: Move logging and caching to the gen_data internal f…
8710994 
…unction (#7046)

Signed-off-by: arunjose696 <arunjose696@gmail.com>
Co-authored-by: Anatoly Myachev <anatoliimyachev@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Benchmarking 🏁 Issues and pull requests for evaluating runtime Needs more information ❔ Issues that require more information from the reporter P3 Very minor bugs, or features we can hopefully add some day.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REFACTOR-#3257: Move logging and caching to the gen_data function arunjose696/modin
2 participants
@RehanSD @amyskov