Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify type of log_level in logging module #4622

Closed
pyrito opened this issue Jun 30, 2022 · 0 comments · Fixed by #6992
Closed

Unify type of log_level in logging module #4622

pyrito opened this issue Jun 30, 2022 · 0 comments · Fixed by #6992
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase good first issue 🔰 Good for newcomers hacktoberfest Help Wanted 🌐 Issues good for external contributors. P3 Very minor bugs, or features we can hopefully add some day.

Comments

@pyrito
Copy link
Collaborator

pyrito commented Jun 30, 2022

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?

The logging module currently has a handful of functions that take in a log_level argument that are ints in some functions and string in other functions. For example, _create_logger in logging/config.py has log_level as an integer where as class_logger.py takes in log_level as a string. This isn't a terribly pressing issue, but we should try to decide on one type for log_level or handle both integers and strings elegantly.
@pyrito pyrito added good first issue 🔰 Good for newcomers Code Quality 💯 Improvements or issues to improve quality of codebase labels Jun 30, 2022
@pyrito pyrito mentioned this issue Jun 30, 2022
Merged
8 tasks
@pyrito pyrito added the P3 Very minor bugs, or features we can hopefully add some day. label Aug 31, 2022
@mvashishtha mvashishtha added hacktoberfest Help Wanted 🌐 Issues good for external contributors. labels Sep 19, 2022
@arunjose696 arunjose696 mentioned this issue Mar 4, 2024
Merged
7 tasks
YarShev added a commit that referenced this issue Mar 4, 2024
@arunjose696 @YarShev
FEAT-#4622: Unify data type of log_level in logging module (#6992)
cd3d0c6 
Co-authored-by: Iaroslav Igoshev <Poolliver868@mail.ru>
Signed-off-by: arunjose696 <arunjose696@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase good first issue 🔰 Good for newcomers hacktoberfest Help Wanted 🌐 Issues good for external contributors. P3 Very minor bugs, or features we can hopefully add some day.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FEAT-#4622: Unify data type of log_level in logging module arunjose696/modin
2 participants
@pyrito @mvashishtha