Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF: avoid to_pandas in Series._reduce_dimension #4765

Open
jbrockmendel opened this issue Aug 3, 2022 · 1 comment
Open

PERF: avoid to_pandas in Series._reduce_dimension #4765

jbrockmendel opened this issue Aug 3, 2022 · 1 comment
Labels
P2 Minor bugs or low-priority feature requests Performance 🚀 Performance related issues and pull requests.

Comments

@jbrockmendel
Copy link
Collaborator

Not clear to me why to_pandas would be necessary. Investigating.
@jbrockmendel
Copy link
Collaborator Author

Looks like the to_pandas is happening on a query_compiler where qc._modin_frame has 1 column and 1 row, so we get a scalar back. This still gets a bunch of overhead from pickling/unpickling index, columns, BlockManager, Block, ...

jbrockmendel added a commit to jbrockmendel/modin that referenced this issue Aug 29, 2022
@jbrockmendel
PERF-modin-project#4765: __getitem__
754b687 
Signed-off-by: Brock <jbrockmendel@gmail.com>
jbrockmendel added a commit to jbrockmendel/modin that referenced this issue Aug 29, 2022
@jbrockmendel
PERF-modin-project#4765: __getitem__
c44b6d3 
Signed-off-by: Brock <jbrockmendel@gmail.com>
@pyrito pyrito added Performance 🚀 Performance related issues and pull requests. P2 Minor bugs or low-priority feature requests labels Aug 31, 2022
@YarShev YarShev closed this as completed Jan 11, 2024
@YarShev YarShev reopened this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Minor bugs or low-priority feature requests Performance 🚀 Performance related issues and pull requests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbrockmendel @pyrito @YarShev