Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: pytest 7.2.0 dropping py from dependencies is causing test failures #5154

Closed
pyrito opened this issue Oct 25, 2022 · 3 comments
Closed

CI: pytest 7.2.0 dropping py from dependencies is causing test failures #5154

pyrito opened this issue Oct 25, 2022 · 3 comments
Labels
bug 🦗 Something isn't working CI dependencies 🔗 Issues related to dependencies P0 Highest priority tasks requiring immediate fix

Comments

@pyrito
Copy link
Collaborator

pyrito commented Oct 25, 2022

See: ionelmc/pytest-benchmark#226 for more context

This is causing failures on master: https://github.com/modin-project/modin/actions/runs/3322482406/jobs/5491562285
@pyrito pyrito added bug 🦗 Something isn't working dependencies 🔗 Issues related to dependencies P0 Highest priority tasks requiring immediate fix CI labels Oct 25, 2022
@pyrito pyrito changed the title CI: pytest 7.2.0 drops py from dependencies causing failures CI: pytest 7.2.0 dropping py from dependencies is causing test failures Oct 25, 2022
@pyrito pyrito mentioned this issue Oct 25, 2022
Closed
7 tasks
pyrito pushed a commit to pyrito/modin that referenced this issue Oct 25, 2022
TEST-modin-project#5154: add py to requirements
832d3ab 
Signed-off-by: Karthik Velayutham <vkarthik@ponder.io>
@pyrito
Copy link
Collaborator Author

pyrito commented Oct 25, 2022

May actually be resolved now: ionelmc/pytest-benchmark#226 (comment)

@mvashishtha
Copy link
Collaborator

pytest-benchmark 4.0.0 should fix this error, but it's not on conda forge yet, so our CI still fails: https://github.com/modin-project/modin/actions/runs/3322482407/jobs/5496407595

@pyrito
Copy link
Collaborator Author

pyrito commented Oct 26, 2022

Issue has been resolved since pytest-benchmark 4.0.0 has been updated on conda forge and pypi.

@pyrito pyrito closed this as completed Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🦗 Something isn't working CI dependencies 🔗 Issues related to dependencies P0 Highest priority tasks requiring immediate fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TEST-#5154: add py to requirements to fix CI failures pyrito/modin
2 participants
@pyrito @mvashishtha