Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: join raises AttributeError: 'list' object has no attribute '_query_compiler' #5203

Closed
3 tasks done
anmyachev opened this issue Nov 7, 2022 · 0 comments · Fixed by #5939
Closed
3 tasks done
Labels
bug 🦗 Something isn't working P1 Important tasks that we should complete soon pandas concordance 🐼 Functionality that does not match pandas

Comments

@anmyachev
Copy link
Collaborator

Modin version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest released version of Modin.

  • I have confirmed this bug exists on the main branch of Modin. (In order to do this you can follow this guide.)

Reproducible Example

import modin.pandas as pd
import numpy as np

df1 = pd.DataFrame(np.ones([2,4]), columns = ['a','b','c','d'])
df2 = pd.DataFrame(np.ones([2,4]), columns = ['a','b','c','d'])
df3 = pd.DataFrame(np.ones([2,4]), columns = ['a','b','c','d'])

df1.join([df2, df3], how="inner", on="a")

Issue Description

Non-obvious error message.

Expected Behavior

In that case we should raise ValueError: Joining multiple DataFrames only supported for joining on index exception as pandas does.

Error Logs

File "test_join.py", line 8, in <module>
    df1.join([df2, df3], how="inner", on="a")
  File "C:\projects\modin\modin\logging\logger_decorator.py", line 128, in run_and_log
    return obj(*args, **kwargs)
  File "C:\projects\modin\modin\_compat\pandas_api\latest\dataframe.py", line 172, in join
    return self._join(
  File "C:\projects\modin\modin\logging\logger_decorator.py", line 128, in run_and_log
    return obj(*args, **kwargs)
  File "C:\projects\modin\modin\pandas\dataframe.py", line 1321, in _join
    other._query_compiler,
AttributeError: 'list' object has no attribute '_query_compiler'

Installed Versions

Replace this line with the output of pd.show_versions()

@anmyachev anmyachev added bug 🦗 Something isn't working pandas concordance 🐼 Functionality that does not match pandas P1 Important tasks that we should complete soon labels Nov 7, 2022
@anmyachev anmyachev changed the title BUG: join raises AttributeError: 'list' object has no attribute '_query_compiler' BUG: join raises AttributeError: 'list' object has no attribute '_query_compiler' Nov 7, 2022
anmyachev added a commit to anmyachev/modin that referenced this issue Apr 5, 2023
… no attribute '_query_compiler' in 'join' op

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev added a commit to anmyachev/modin that referenced this issue Apr 6, 2023
… no attribute '_query_compiler' in 'join' op

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
dchigarev pushed a commit that referenced this issue Apr 12, 2023
…e '_query_compiler'` in `join` op (#5939)

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev added a commit to anmyachev/modin that referenced this issue Apr 13, 2023
…s no attribute '_query_compiler'` in `join` op (modin-project#5939)

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev added a commit that referenced this issue Apr 24, 2023
…e '_query_compiler'` in `join` op (#5939)

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🦗 Something isn't working P1 Important tasks that we should complete soon pandas concordance 🐼 Functionality that does not match pandas
Projects
None yet
1 participant