Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible to remove to_pandas calls in merge and join operations #6849

Closed
arunjose696 opened this issue Jan 10, 2024 · 1 comment · Fixed by #6850
Closed

Possible to remove to_pandas calls in merge and join operations #6849

arunjose696 opened this issue Jan 10, 2024 · 1 comment · Fixed by #6850

Comments

@arunjose696
Copy link
Collaborator

arunjose696 commented Jan 10, 2024 •
edited

In query_compiler.merge and query_compiler.join we use to_pandas() eg right_pandas = right.to_pandas() in This operation in the main thread is blocking. This could be expensive if the right dataframe size is too large.

It is possible to remove the to_pandas calls by replacing apply_full_axis with broadcast_apply_full_axis and pass the right dataframe to broadcast_apply_full_axis as Originally suggested by @YarShev in #5524 (comment) and
@arunjose696 arunjose696 mentioned this issue Jan 10, 2024
Merged
7 tasks
@anmyachev
Copy link
Collaborator

Related issue: #4711

@YarShev YarShev mentioned this issue Jan 10, 2024
Closed
anmyachev pushed a commit that referenced this issue Jan 11, 2024
@arunjose696
FEAT-#6849: Removing to_pandas call in merge and join functions (…
45ad9de 
…#6850)

Signed-off-by: arunjose696 <arunjose696@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FEAT-#6849: Removing to_pandas call in merge function arunjose696/modin
2 participants
@arunjose696 @anmyachev