Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fails after release of pytest 8.0.0 #6893

Closed
dchigarev opened this issue Jan 29, 2024 · 1 comment · Fixed by #6894
Closed

CI fails after release of pytest 8.0.0 #6893

dchigarev opened this issue Jan 29, 2024 · 1 comment · Fixed by #6894
Assignees
Labels
P0 Highest priority tasks requiring immediate fix Testing 📈 Issues related to testing

Comments

@dchigarev
Copy link
Collaborator

dchigarev commented Jan 29, 2024

https://github.com/modin-project/modin/actions/runs/7697508576/job/20974753158?pr=6862

the following code fails starting with pytest 8.0.0 (example in our tests)

import pytest
import warnings

try:
    with pytest.warns(UserWarning, match="Warning"):
        raise TypeError("Hello")
        warnings.warn("Warning", UserWarning)
        x = 10
except TypeError:
    pass

# Failed: DID NOT WARN. No warnings of type (<class 'UserWarning'>,) were emitted.
#  Emitted warnings: [].
@dchigarev dchigarev added Testing 📈 Issues related to testing P0 Highest priority tasks requiring immediate fix labels Jan 29, 2024
@dchigarev dchigarev self-assigned this Jan 29, 2024
@dchigarev
Copy link
Collaborator Author

this is now expected behavior since 8.0.0: pytest-dev/pytest#9036
so we have to fix it on our side

dchigarev added a commit to dchigarev/modin that referenced this issue Jan 29, 2024
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
anmyachev pushed a commit that referenced this issue Jan 29, 2024
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Highest priority tasks requiring immediate fix Testing 📈 Issues related to testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant