Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate definitions of create_test_series in tests #6903

Closed
dchigarev opened this issue Feb 1, 2024 · 0 comments · Fixed by #6910
Closed

Remove duplicate definitions of create_test_series in tests #6903

dchigarev opened this issue Feb 1, 2024 · 0 comments · Fixed by #6910
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase P2 Minor bugs or low-priority feature requests Testing 📈 Issues related to testing

Comments

@dchigarev
Copy link
Collaborator

We should only have this function in modin/pandas/test/utils.py and import it from there

modin/modin/pandas/test/test_series.py

Line 230 in 3e42b8b

def create_test_series(vals, sort=False, **kwargs):

modin/modin/pandas/test/utils.py

Line 1036 in 3e42b8b

def create_test_series(*args, **kwargs):

modin/modin/pandas/test/test_rolling.py

Line 53 in 3e42b8b

def create_test_series(vals):

modin/modin/pandas/test/test_expanding.py

Line 34 in 3e42b8b

def create_test_series(vals):

@dchigarev dchigarev added Code Quality 💯 Improvements or issues to improve quality of codebase Testing 📈 Issues related to testing P2 Minor bugs or low-priority feature requests labels Feb 1, 2024
@dchigarev dchigarev mentioned this issue Feb 1, 2024
Merged
7 tasks
dchigarev added a commit to dchigarev/modin that referenced this issue Feb 5, 2024
@dchigarev
REFACTOR-modin-project#6903: Remove duplicated definitions of 'create…
eac03a7 
…_test_series'

Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev dchigarev mentioned this issue Feb 5, 2024
Merged
7 tasks
anmyachev pushed a commit that referenced this issue Feb 5, 2024
@dchigarev
REFACTOR-#6903: Remove duplicated definitions of 'create_test_series' (…
01c529c 
…#6910)

Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase P2 Minor bugs or low-priority feature requests Testing 📈 Issues related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REFACTOR-#6903: Remove duplicated definitions of 'create_test_series' dchigarev/modin
1 participant
@dchigarev