Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for pydantic 2 #6916

Closed
achieveordie opened this issue Feb 6, 2024 · 3 comments · Fixed by #6917
Closed

Add Support for pydantic 2 #6916

achieveordie opened this issue Feb 6, 2024 · 3 comments · Fixed by #6917
Labels
dependencies 🔗 Issues related to dependencies External Pull requests and issues from people who do not regularly contribute to modin new feature/request 💬 Requests and pull requests for new features P1 Important tasks that we should complete soon

Comments

@achieveordie
Copy link

Is your feature request related to a problem? Please describe.
An explicit restriction was added to the requirements. However, ray seems to support 2.5+ version of pydantic. Are there any more reasons to restrict it to 1.x?

Check out this commit which adds that functionality. It'll be really helpful if we could use modin with latest versions of pydantic.
@achieveordie achieveordie added new feature/request 💬 Requests and pull requests for new features Triage 🩹 Issues that need triage labels Feb 6, 2024
@anmyachev
Copy link
Collaborator

Hi @achieveordie! I will try to unpin it.

@anmyachev anmyachev added External Pull requests and issues from people who do not regularly contribute to modin dependencies 🔗 Issues related to dependencies P1 Important tasks that we should complete soon and removed Triage 🩹 Issues that need triage labels Feb 6, 2024
anmyachev added a commit to anmyachev/modin that referenced this issue Feb 6, 2024
@anmyachev
FIX-modin-project#6916: unpin 'pydantic' dependency
0892e24 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev mentioned this issue Feb 6, 2024
Merged
7 tasks
YarShev pushed a commit that referenced this issue Feb 6, 2024
@anmyachev
FIX-#6916: unpin 'pydantic' dependency (#6917)
33b3834 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
Copy link
Collaborator

@achieveordie Modin 0.27.0 (planning release date: 14 February) will not require pydantic<2.

@achieveordie
Copy link
Author

Thanks! @anmyachev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies 🔗 Issues related to dependencies External Pull requests and issues from people who do not regularly contribute to modin new feature/request 💬 Requests and pull requests for new features P1 Important tasks that we should complete soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX-#6916: unpin pydantic dependency anmyachev/modin
2 participants
@anmyachev @achieveordie