Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove enable_api_only mode in modin logging #7102

Closed
arunjose696 opened this issue Mar 18, 2024 · 1 comment · Fixed by #7114 or #7194
Closed

Remove enable_api_only mode in modin logging #7102

arunjose696 opened this issue Mar 18, 2024 · 1 comment · Fixed by #7114 or #7194

Comments

@arunjose696
Copy link
Collaborator

In modin LogMode enable_api_only and enable options looks confusing. We should just leave enable option, using which memory.log would also should be generated

Originally posted by @YarShev in #7092 (comment)
@arunjose696 arunjose696 mentioned this issue Mar 25, 2024
Merged
7 tasks
YarShev pushed a commit that referenced this issue Mar 25, 2024
@arunjose696
FEAT-#7102: Deprecate enable_api_only mode in modin logging (#7114)
2b958e9 
Signed-off-by: Iaroslav Igoshev <iaroslav.igoshev@intel.com>
@YarShev
Copy link
Collaborator

YarShev commented Mar 25, 2024

Reopening as enable_api_only was deprecated and should be removed in a future release.

@YarShev YarShev reopened this Mar 25, 2024
@arunjose696 arunjose696 mentioned this issue Apr 17, 2024
Merged
7 tasks
anmyachev pushed a commit that referenced this issue Apr 17, 2024
@arunjose696
FIX-#7102: Remove enable_api_only mode in modin logging (#7194)
615f975 
Signed-off-by: arunjose696 <arunjose696@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@YarShev @arunjose696