Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitrevision errors #82

Closed
simon-mo opened this issue Sep 21, 2018 · 0 comments · Fixed by #97
Closed

gitrevision errors #82

simon-mo opened this issue Sep 21, 2018 · 0 comments · Fixed by #97
Assignees
Labels
bug 🦗 Something isn't working good first issue 🔰 Good for newcomers

Comments

@simon-mo
Copy link
Collaborator

git_revision = _execute_cmd_in_temp_env(['git', 'rev-parse', 'HEAD'])

Current git revision tries to find the git commit by executing Popen directly from user process. This will start wherever user process start, which might not be a git repository. To fix it, we just need to run above line inside modin.__file__ or something like that.

@simon-mo simon-mo added the good first issue 🔰 Good for newcomers label Sep 21, 2018
@devin-petersohn devin-petersohn self-assigned this Sep 28, 2018
@devin-petersohn devin-petersohn added the bug 🦗 Something isn't working label Sep 28, 2018
dchigarev pushed a commit to dchigarev/modin that referenced this issue Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🦗 Something isn't working good first issue 🔰 Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants