Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a fix to Groupby for aggregations by a column from the DataFrame #413

Merged
merged 7 commits into from Jan 20, 2019
Merged

Add a fix to Groupby for aggregations by a column from the DataFrame #413

merged 7 commits into from Jan 20, 2019

Commits on Jan 17, 2019

  1. Add a fix to Groupby for aggregations by a column from the DataFrame 

    * Resolves modin-project#409
* Removes a grouped column from the result to match pandas
* Changes the way we compute `size` to match pandas
* Adds consisntecy between the DataFrame being computed on and the result
    @devin-petersohn
    devin-petersohn committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    e5cfc51 View commit details
    Browse the repository at this point in the history

  2. Additional updates for groupby + agg: 

    * Computing columns more directly now. We reset the index or columns and
  use those indices to compute that actual index externally. This is
  more correct (and was actually being computed previously, but
  incorrectly).
* Adding **kwargs to `modin.pandas.groupby.DataFrameGroupby.rank`
* Adding tests for string + integer inter-operations
* Cleaning up and making some code more consistent
    @devin-petersohn
    devin-petersohn committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    633cd3c View commit details
    Browse the repository at this point in the history

  3. Fix lint and version issue

    @devin-petersohn
    devin-petersohn committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    3d5202c View commit details
    Browse the repository at this point in the history

  4. Fix lint

    @devin-petersohn
    devin-petersohn committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    9e5632e View commit details
    Browse the repository at this point in the history

  5. Making sort correct for python2

    @devin-petersohn
    devin-petersohn committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    aed3f2f View commit details
    Browse the repository at this point in the history

  6. Fix lint

    @devin-petersohn
    devin-petersohn committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    ae67460 View commit details
    Browse the repository at this point in the history

  7. Python2 and Python3 compat fix

    @devin-petersohn
    devin-petersohn committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    b814a5f View commit details
    Browse the repository at this point in the history