Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing path and line number from warnings. #447

Merged

Conversation

devin-petersohn
Copy link
Collaborator

@devin-petersohn devin-petersohn commented Feb 1, 2019

  • Declutters the warning message so the message is easier to see
  • Removes the warnings.warn(message) from the message as well.
  • Difference between old and new shown below:

Previous:

/Users/DevinPetersohn/software_builds/modin/modin/error_message.py:32: UserWarning: `cov` defaulting to pandas implementation.
To request implementation, send an email to feature_requests@modin.org.
  warnings.warn(message)

This commit:

UserWarning: `cov` defaulting to pandas implementation.
To request implementation, send an email to feature_requests@modin.org.
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • passes black --check modin/

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-Performance-PRB/344/
Test PASSed.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/405/
Test PASSed.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-Performance-PRB/345/
Test PASSed.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/406/
Test PASSed.

* Declutters the warning message so the message is easier to see
* Removes the `warnings.warn(message)` from the message as well.
* Difference between old and new shown below:

Previous:
```
/Users/DevinPetersohn/software_builds/modin/modin/error_message.py:32: UserWarning: `cov` defaulting to pandas implementation.
To request implementation, send an email to feature_requests@modin.org.
  warnings.warn(message)
```

This commit:
```
WARN: `cov` defaulting to pandas implementation.
To request implementation, send an email to feature_requests@modin.org.
```
@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/474/
Test PASSed.

@codecov
Copy link

codecov bot commented Feb 6, 2019

Codecov Report

Merging #447 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
+ Coverage   83.23%   83.24%   +0.01%     
==========================================
  Files          33       33              
  Lines        4498     4501       +3     
==========================================
+ Hits         3744     3747       +3     
  Misses        754      754
Impacted Files Coverage Δ
modin/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66bef31...e4f073c. Read the comment docs.

@devin-petersohn devin-petersohn merged commit 5f72f94 into modin-project:master Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants