Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#4589: Pin protobuf<4.0.0 to fix ray. #4590

Merged
merged 2 commits into from Jun 21, 2022

Conversation

mvashishtha
Copy link
Collaborator

Signed-off-by: mvashishtha mahesh@ponder.io

What do these changes do?

  • commit message follows format outlined here
  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves CI downloads protobuf 4.21.1 and ray 1.12.1, which are incompatible. #4589
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date
  • added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

Signed-off-by: mvashishtha <mahesh@ponder.io>
@mvashishtha mvashishtha requested a review from a team as a code owner June 21, 2022 20:06
Signed-off-by: mvashishtha <mahesh@ponder.io>
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #4590 (235fbda) into master (81648e7) will increase coverage by 3.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4590      +/-   ##
==========================================
+ Coverage   86.63%   89.76%   +3.13%     
==========================================
  Files         228      229       +1     
  Lines       18420    18696     +276     
==========================================
+ Hits        15958    16783     +825     
+ Misses       2462     1913     -549     
Impacted Files Coverage Δ
modin/experimental/batch/test/test_pipeline.py 100.00% <0.00%> (ø)
modin/pandas/base.py 94.82% <0.00%> (+0.08%) ⬆️
...mentations/pandas_on_ray/partitioning/partition.py 93.57% <0.00%> (+1.83%) ⬆️
...tations/pandas_on_python/partitioning/partition.py 93.75% <0.00%> (+2.08%) ⬆️
...entations/pandas_on_dask/partitioning/partition.py 91.46% <0.00%> (+2.43%) ⬆️
modin/pandas/__init__.py 69.69% <0.00%> (+3.03%) ⬆️
modin/config/envvars.py 89.10% <0.00%> (+3.46%) ⬆️
...dataframe/pandas/partitioning/partition_manager.py 90.52% <0.00%> (+3.50%) ⬆️
modin/error_message.py 89.36% <0.00%> (+6.38%) ⬆️
modin/experimental/cloud/meta_magic.py 93.54% <0.00%> (+8.06%) ⬆️
... and 12 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Collaborator

@RehanSD RehanSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this to the env no engine yaml? @YarShev sufgested doing so on the last PR. Besides that, LGTM!

@mvashishtha
Copy link
Collaborator Author

@RehanSD, @YarShev says here that he wants to pin the protobuf level there because that file is used in the test test-ray-master, but ray master already requires protobuf < 4.0.0, as I mentioned here.

@RehanSD
Copy link
Collaborator

RehanSD commented Jun 21, 2022

@RehanSD, @YarShev says here that he wants to pin the protobuf level there because that file is used in the test test-ray-master, but ray master already requires protobuf < 4.0.0, as I mentioned here.

Makes sense to me!

Copy link
Collaborator

@RehanSD RehanSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RehanSD RehanSD merged commit c360515 into modin-project:master Jun 21, 2022
RehanSD pushed a commit that referenced this pull request Jun 24, 2022
Signed-off-by: mvashishtha <mahesh@ponder.io>
RehanSD pushed a commit that referenced this pull request Jun 24, 2022
Signed-off-by: mvashishtha <mahesh@ponder.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI downloads protobuf 4.21.1 and ray 1.12.1, which are incompatible.
3 participants