Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT-#4598: Add support for pandas 1.4.3 #4599

Merged
merged 3 commits into from Jun 23, 2022

Conversation

RehanSD
Copy link
Collaborator

@RehanSD RehanSD commented Jun 23, 2022

Signed-off-by: Rehan Durrani rehan@ponder.io

What do these changes do?

  • commit message follows format outlined here
  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Bump supported pandas version to 1.4.3 #4598 ?
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date
  • added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

Signed-off-by: Rehan Durrani <rehan@ponder.io>
@RehanSD RehanSD requested a review from a team as a code owner June 23, 2022 18:48
Signed-off-by: Rehan Durrani <rehan@ponder.io>
Signed-off-by: Rehan Durrani <rehan@ponder.io>
Copy link
Collaborator

@pyrito pyrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #4599 (182e439) into master (fde216d) will increase coverage by 3.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4599      +/-   ##
==========================================
+ Coverage   86.48%   89.66%   +3.17%     
==========================================
  Files         230      231       +1     
  Lines       18444    18720     +276     
==========================================
+ Hits        15952    16785     +833     
+ Misses       2492     1935     -557     
Impacted Files Coverage Δ
modin/pandas/__init__.py 69.69% <100.00%> (+3.03%) ⬆️
modin/experimental/batch/test/test_pipeline.py 100.00% <0.00%> (ø)
modin/pandas/base.py 94.82% <0.00%> (+0.08%) ⬆️
modin/core/storage_formats/pandas/parsers.py 90.22% <0.00%> (+1.26%) ⬆️
...mentations/pandas_on_ray/partitioning/partition.py 93.57% <0.00%> (+1.83%) ⬆️
...tations/pandas_on_python/partitioning/partition.py 93.75% <0.00%> (+2.08%) ⬆️
...entations/pandas_on_dask/partitioning/partition.py 91.46% <0.00%> (+2.43%) ⬆️
modin/config/envvars.py 89.10% <0.00%> (+3.46%) ⬆️
...dataframe/pandas/partitioning/partition_manager.py 90.52% <0.00%> (+3.50%) ⬆️
... and 15 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Collaborator

@naren-ponder naren-ponder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending CI passing

Copy link
Collaborator

@YarShev YarShev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RehanSD, LGTM, thanks!

@YarShev YarShev merged commit 53ca4f3 into modin-project:master Jun 23, 2022
RehanSD added a commit that referenced this pull request Jun 24, 2022
Signed-off-by: Rehan Durrani <rehan@ponder.io>
RehanSD added a commit that referenced this pull request Jun 24, 2022
Signed-off-by: Rehan Durrani <rehan@ponder.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump supported pandas version to 1.4.3
4 participants