Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#4604: fix groupby+agg in case when multicolumn can arise #4642

Merged
merged 5 commits into from Jul 5, 2022
Merged

FIX-#4604: fix groupby+agg in case when multicolumn can arise #4642

merged 5 commits into from Jul 5, 2022

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Jul 4, 2022 •
edited

Signed-off-by: Myachev anatoly.myachev@intel.com

What do these changes do?

  • commit message follows format outlined here
  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Bug with complex groupby on copied columns #4604
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date
  • added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

@anmyachev anmyachev requested a review from a team as a code owner July 4, 2022 09:41
@anmyachev anmyachev force-pushed the issue4604 branch 2 times, most recently from 722f534 to 40da79f Compare July 4, 2022 09:59
@anmyachev
FIX-modin-project#4604: fix groupby+agg in case when multicolumn can …
bd26aa0 
…arise

Signed-off-by: Myachev <anatoly.myachev@intel.com>
@codecov
Copy link

codecov bot commented Jul 4, 2022 •
edited

Codecov Report

Merging #4642 (7aacdaa) into master (82746b9) will increase coverage by 3.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4642      +/-   ##
==========================================
+ Coverage   86.57%   89.59%   +3.02%     
==========================================
  Files         230      231       +1     
  Lines       18457    18735     +278     
==========================================
+ Hits        15979    16786     +807     
+ Misses       2478     1949     -529
Impacted Files Coverage Δ
modin/pandas/groupby.py 93.71% <100.00%> (+0.03%) ⬆️
...odin/core/storage_formats/pandas/query_compiler.py 96.08% <0.00%> (-0.09%) ⬇️
modin/experimental/batch/test/test_pipeline.py 94.56% <0.00%> (ø)
modin/pandas/base.py 95.30% <0.00%> (+0.08%) ⬆️
...mentations/pandas_on_ray/partitioning/partition.py 93.57% <0.00%> (+1.83%) ⬆️
...tations/pandas_on_python/partitioning/partition.py 93.75% <0.00%> (+2.08%) ⬆️
...entations/pandas_on_dask/partitioning/partition.py 91.46% <0.00%> (+2.43%) ⬆️
modin/pandas/__init__.py 69.69% <0.00%> (+3.03%) ⬆️
modin/config/envvars.py 89.10% <0.00%> (+3.46%) ⬆️
...dataframe/pandas/partitioning/partition_manager.py 90.52% <0.00%> (+3.50%) ⬆️
... and 14 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

YarShev
YarShev reviewed Jul 4, 2022
View reviewed changes
modin/pandas/groupby.py Show resolved Hide resolved
modin/pandas/test/test_groupby.py Outdated Show resolved Hide resolved
@anmyachev
FIX-modin-project#4604: address review comments
c0ee221 
Signed-off-by: Myachev <anatoly.myachev@intel.com>
anmyachev and others added 3 commits July 4, 2022 20:26
@anmyachev @YarShev
Apply suggestions from code review
c22f43d 
Co-authored-by: Yaroslav Igoshev <Poolliver868@mail.ru>
@anmyachev
fixes
692e801 
Signed-off-by: Myachev <anatoly.myachev@intel.com>
@anmyachev
revert changes
7aacdaa 
Signed-off-by: Myachev <anatoly.myachev@intel.com>
YarShev
YarShev approved these changes Jul 5, 2022
View reviewed changes
Copy link
Collaborator

@YarShev YarShev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anmyachev, LGTM, assuming tests pass, thanks!

@YarShev YarShev merged commit ce1d93a into modin-project:master Jul 5, 2022
@anmyachev anmyachev deleted the issue4604 branch July 5, 2022 09:37
YarShev added a commit that referenced this pull request Sep 6, 2022
@anmyachev @YarShev
FIX-#4604: fix groupby+agg in case when multicolumn can arise (#4642)
377c3e0 
Co-authored-by: Yaroslav Igoshev <Poolliver868@mail.ru>
Signed-off-by: Myachev <anatoly.myachev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug with complex groupby on copied columns
2 participants
@anmyachev @YarShev