New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix loc with MultiIndex #508
Fix loc with MultiIndex #508
Conversation
Merged build finished. Test FAILed. |
Test FAILed. |
Codecov Report
@@ Coverage Diff @@
## master #508 +/- ##
==========================================
+ Coverage 90.12% 90.17% +0.05%
==========================================
Files 35 35
Lines 4828 4836 +8
==========================================
+ Hits 4351 4361 +10
+ Misses 477 475 -2
Continue to review full report at Codecov.
|
Merged build finished. Test FAILed. |
Test FAILed. |
Merged build finished. Test FAILed. |
Test FAILed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick catch @devin-petersohn! Just some questions, which might be good places to include inline docs for
Merged build finished. Test FAILed. |
Test FAILed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Let's wait for the tests to pass before merging
What do these changes do?
Handles correctly the case where the index is a MultiIndex
Related issue number
Resolves #504
flake8 modin
black --check modin