Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loc with MultiIndex #508

Merged
merged 5 commits into from Mar 22, 2019

Conversation

devin-petersohn
Copy link
Collaborator

What do these changes do?

Handles correctly the case where the index is a MultiIndex

Related issue number

Resolves #504

  • passes flake8 modin
  • passes black --check modin
  • tests added and passing

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/627/
Test FAILed.

@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #508 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #508      +/-   ##
==========================================
+ Coverage   90.12%   90.17%   +0.05%     
==========================================
  Files          35       35              
  Lines        4828     4836       +8     
==========================================
+ Hits         4351     4361      +10     
+ Misses        477      475       -2
Impacted Files Coverage Δ
modin/pandas/indexing.py 80.76% <100%> (+1.91%) ⬆️
...management/query_compiler/pandas_query_compiler.py 90.51% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 633aa6a...2b85757. Read the comment docs.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/629/
Test FAILed.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/630/
Test FAILed.

Copy link
Collaborator

@williamma12 williamma12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick catch @devin-petersohn! Just some questions, which might be good places to include inline docs for

modin/pandas/indexing.py Show resolved Hide resolved
@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/631/
Test FAILed.

Copy link
Collaborator

@williamma12 williamma12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's wait for the tests to pass before merging

@devin-petersohn devin-petersohn merged commit bf15103 into modin-project:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiIndex .loc fails on modin and works on pandas
3 participants