Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#5138: df_categories_equals typo #5250

Merged
merged 1 commit into from
Nov 23, 2022
Merged

FIX-#5138: df_categories_equals typo #5250

merged 1 commit into from
Nov 23, 2022

Conversation

noloerino
Copy link
Collaborator

@noloerino noloerino commented Nov 22, 2022 •
edited

What do these changes do?

Fixes a redundant comparison caused by a typo.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: df_categories_equal typo? #5138
  • module layout described at docs/development/architecture.rst is up-to-date

@noloerino
FIX-modin-project#5138: df_categories_equals typo
18b5a52 
Signed-off-by: Jonathan Shi <jhshi@ponder.io>
@noloerino noloerino requested a review from a team as a code owner November 22, 2022 23:44
mvashishtha
mvashishtha approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@mvashishtha mvashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; wil pray that CI passes 🙏

@noloerino
Copy link
Collaborator Author

Notebook tests are hitting an HTTP 403 error, hopefully it's a flake? https://github.com/modin-project/modin/actions/runs/3527986556/jobs/5917612405

@vnlitvinov
Copy link
Collaborator

CI is a fluke caused by #5252

@vnlitvinov vnlitvinov merged commit 7b1ae5a into modin-project:master Nov 23, 2022
@noloerino noloerino deleted the cat-typo branch November 23, 2022 21:15
dchigarev pushed a commit that referenced this pull request Nov 25, 2022
@noloerino @dchigarev
FIX-#5138: df_categories_equals typo (#5250)
9d455ac 
Signed-off-by: Jonathan Shi <jhshi@ponder.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvashishtha mvashishtha mvashishtha approved these changes

@vnlitvinov vnlitvinov vnlitvinov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: df_categories_equal typo?
3 participants
@noloerino @vnlitvinov @mvashishtha