Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parallelism parameter to read_sql() #455 #594

Merged
merged 1 commit into from Apr 29, 2019

Conversation

ipacheco-uy
Copy link
Contributor

What do these changes do?

Add parameter to limit parallel read_sql connections to the minimum of max_sessions, now it is only limited in cpu count.

Related issue number

#455

  • passes flake8 modin
  • passes black --check modin
  • tests added and passing

@codecov
Copy link

codecov bot commented Apr 27, 2019

Codecov Report

Merging #594 into master will decrease coverage by 0.01%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #594      +/-   ##
==========================================
- Coverage   90.42%   90.41%   -0.02%     
==========================================
  Files          37       37              
  Lines        5472     5476       +4     
==========================================
+ Hits         4948     4951       +3     
- Misses        524      525       +1
Impacted Files Coverage Δ
modin/experimental/pandas/io_exp.py 100% <ø> (ø) ⬆️
modin/experimental/engines/pandas_on_ray/io_exp.py 38.88% <0%> (ø) ⬆️
modin/data_management/factories.py 94.44% <75%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cef850d...f46a3bf. Read the comment docs.

Copy link
Collaborator

@williamma12 williamma12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr, @ipacheco-uy! I think we can ignore the code coverage changes though we might want to use this opportunity to add in a # pragma: no cover to the ExperimentalBaseFactory.

What do you think, @devin-petersohn?

@devin-petersohn
Copy link
Collaborator

@williamma12 I think it's a bit out of scope for this PR, we can leave as-is.

@devin-petersohn devin-petersohn merged commit 371bc48 into modin-project:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants