Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF-#5841: Precompute dtypes for boolean setitem #5952

Merged
merged 5 commits into from Apr 19, 2023
Merged

PERF-#5841: Precompute dtypes for boolean setitem #5952

merged 5 commits into from Apr 19, 2023

Conversation

dchigarev
Copy link
Collaborator

@dchigarev dchigarev commented Apr 6, 2023 •
edited

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Precompute new dtype for boolean setitem #5841
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@dchigarev
PERF-modin-project#5841: Precompute dtypes on boolean setitem
f83e4b2 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev
Fix scalar case
c67ea79 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev dchigarev added the Blocked ❌ A pull request that is blocked label Apr 10, 2023
@dchigarev
Merge remote-tracking branch 'origin/master' into issue_5841
208afaf
@dchigarev
Add more tests
e874a2f 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev dchigarev removed the Blocked ❌ A pull request that is blocked label Apr 18, 2023
@dchigarev dchigarev marked this pull request as ready for review April 18, 2023 13:39
@dchigarev dchigarev requested a review from a team as a code owner April 18, 2023 13:39
anmyachev
anmyachev previously approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@anmyachev anmyachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dchigarev @anmyachev
Update modin/core/storage_formats/pandas/query_compiler.py
cbbbe91 
Co-authored-by: Anatoly Myachev <anatoliimyachev@mail.com>
@anmyachev anmyachev merged commit ab90115 into modin-project:master Apr 19, 2023
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmyachev anmyachev anmyachev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Precompute new dtype for boolean setitem
2 participants
@dchigarev @anmyachev