FIX-#6107: Allow pass through of tz_convert and tz_localize to QC if possible
#6137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calize` to QC if possible Signed-off-by: Rehan Durrani <rehan@ponder.io>
vnlitvinov
reviewed
May 16, 2023
modin/pandas/base.py
Outdated
| if level is not None: | ||
| new_labels = ( | ||
| pandas.Series(index=self.axes[axis]).tz_convert(tz, level=level).index | ||
| if hasattr(self._query_compiler, "tz_convert"): |
There was a problem hiding this comment.
this doesn't feel right... I would propose to require this method but default-to-pandas in normal implementation.
This way - allowing different QCs to have or not to have a method - opens a can of worms IMHO I would rather not let be opened...
There was a problem hiding this comment.
Makes sense - let me wait on #6145 for this PR then, since we'll need the base's _create_or_update_inplace for these
Signed-off-by: Rehan Durrani <rehan@ponder.io>
Signed-off-by: Rehan Durrani <rehan@ponder.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date