FIX-#6201: align groupby objects signatures with pandas #6202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dchigarev
previously approved these changes
May 25, 2023
modin/pandas/groupby.py
Outdated
Comment on lines
754
to
755
| if engine is not None and engine_kwargs is not None: | ||
| return self._default_to_pandas( |
There was a problem hiding this comment.
we should eventually do this for every method that can take the engine parameters, probably as a part of a separate PR sometime in the future
There was a problem hiding this comment.
I will do this right now.
Co-authored-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
commented
May 25, 2023
| @@ -278,12 +278,22 @@ def value_counts( | |||
| ) | |||
| ) | |||
|
|
|||
| def mean(self, numeric_only=None): | |||
| def mean(self, numeric_only=no_default, engine="cython", engine_kwargs=None): | |||
| if engine not in ("cython", None) and engine_kwargs is not None: | |||
There was a problem hiding this comment.
cython is the default value that pandas converts None value to. For example, https://pandas.pydata.org/pandas-docs/version/1.5.3/reference/api/pandas.core.groupby.GroupBy.std.html?highlight=std#pandas.core.groupby.GroupBy.std
dchigarev
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date