Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#6259: Fix astype("category") causing read-only buffer error #6267

Merged
merged 3 commits into from
Jun 14, 2023
Merged

FIX-#6259: Fix astype("category") causing read-only buffer error #6267

merged 3 commits into from
Jun 14, 2023

Conversation

mvashishtha
Copy link
Collaborator

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: ValueError: buffer source array is read-only #6259
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

FIX-modin-project#6259: Fix astype(category) causing read-only buffer…
6caf914 
… error

Signed-off-by: mvashishtha <mahesh@ponder.io>
@mvashishtha mvashishtha requested a review from a team as a code owner June 14, 2023 00:07
@mvashishtha mvashishtha mentioned this pull request Jun 14, 2023
Closed
mvashishtha added 2 commits June 14, 2023 00:12
Fix docstring and hdk
411a104 
Signed-off-by: mvashishtha <mahesh@ponder.io>
Make xfail strict and fix typo
1ce88f5 
Signed-off-by: mvashishtha <mahesh@ponder.io>
@YarShev YarShev changed the title FIX-#6259: Fix astype(category) causing read-only buffer error FIX-#6259: Fix astype("category") causing read-only buffer error Jun 14, 2023
@YarShev YarShev merged commit a882ece into modin-project:master Jun 14, 2023
49 of 50 checks passed
anmyachev pushed a commit that referenced this pull request Jun 14, 2023
@mvashishtha @anmyachev
FIX-#6259: Fix astype("category") causing read-only buffer error (#6267)
90f56e6 
Signed-off-by: mvashishtha <mahesh@ponder.io>
@vnlitvinov vnlitvinov mentioned this pull request Jun 15, 2023
Closed
@anmyachev anmyachev mentioned this pull request Nov 1, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: ValueError: buffer source array is read-only
2 participants
@mvashishtha @YarShev