Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support boolean indexers and other properties in loc #635

Merged
merged 3 commits into from May 26, 2019

Conversation

devin-petersohn
Copy link
Collaborator

@devin-petersohn devin-petersohn commented May 24, 2019

What do these changes do?

Related issue number

  • passes flake8 modin
  • passes black --check modin
  • tests added and passing

* Resolves modin-project#610
* Adds a fastrack to lists of columns and boolean indexers
@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #635 into master will increase coverage by 0.05%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
+ Coverage   90.43%   90.49%   +0.05%     
==========================================
  Files          37       37              
  Lines        5552     5563      +11     
==========================================
+ Hits         5021     5034      +13     
+ Misses        531      529       -2
Impacted Files Coverage Δ
modin/backends/pandas/query_compiler.py 92.31% <100%> (+0.01%) ⬆️
modin/pandas/indexing.py 80.72% <88.88%> (-0.15%) ⬇️
modin/pandas/base.py 94.91% <0%> (+0.2%) ⬆️
modin/pandas/dataframe.py 89.66% <0%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11581d5...df100bc. Read the comment docs.

modin/backends/pandas/query_compiler.py Show resolved Hide resolved
modin/pandas/indexing.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@williamma12 williamma12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @devin-petersohn

@williamma12 williamma12 merged commit 484d36c into modin-project:master May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loc gives incorrect values when given a Boolean indexer
2 participants