Fix usecols when the string name of the column is provided
#652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Resolves modin-project#650 * Adds validation checks for argument * Converts string value to numeric index before shipping to partition * Add tests/testfile
Codecov Report
@@ Coverage Diff @@
## master #652 +/- ##
=========================================
+ Coverage 90.49% 90.5% +0.01%
=========================================
Files 37 37
Lines 5597 5604 +7
=========================================
+ Hits 5065 5072 +7
Misses 532 532
Continue to review full report at Codecov.
|
williamma12
approved these changes
Jun 5, 2019
|
This pull request has been mentioned on Modin Discuss. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue number
flake8 modinblack --check modin