Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `usecols` when the string name of the column is provided #652

Merged
merged 1 commit into from Jun 5, 2019

Conversation

@devin-petersohn
Copy link
Member

commented Jun 5, 2019

  • Resolves #650
  • Adds validation checks for argument
  • Converts string value to numeric index before shipping to partition
  • Add tests/testfile

What do these changes do?

Related issue number

  • passes flake8 modin
  • passes black --check modin
  • tests added and passing
Fix `usecols` when the string name of the column is provided
* Resolves #650
* Adds validation checks for argument
* Converts string value to numeric index before shipping to partition
* Add tests/testfile
@codecov

This comment has been minimized.

Copy link

commented Jun 5, 2019

Codecov Report

Merging #652 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #652      +/-   ##
=========================================
+ Coverage   90.49%   90.5%   +0.01%     
=========================================
  Files          37      37              
  Lines        5597    5604       +7     
=========================================
+ Hits         5065    5072       +7     
  Misses        532     532
Impacted Files Coverage Δ
modin/engines/ray/generic/io.py 93.82% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5c2f2b...e831729. Read the comment docs.

@williamma12
Copy link
Collaborator

left a comment

Looks good @devin-petersohn!

@williamma12 williamma12 merged commit 565ce87 into modin-project:master Jun 5, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 90.49%)
Details
codecov/project 90.5% (+0.01%) compared to d5c2f2b
Details
@modin-bot

This comment has been minimized.

Copy link

commented Jun 19, 2019

This pull request has been mentioned on Modin Discuss. There might be relevant details there:

https://discuss.modin.org/t/modin-0-5-3-release-notes/66/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.