Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST-#6708: Create test files using tmp_path fixture #6709

Merged
merged 4 commits into from Jan 17, 2024
Merged

TEST-#6708: Create test files using tmp_path fixture #6709

merged 4 commits into from Jan 17, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Nov 5, 2023 •
edited

What do these changes do?

This change will ensure that test files no longer clutter up the current working directory.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Create test files using tmp_path fixture #6708
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
TEST-modin-project#6708: Create test files using 'tmp_path' fixture
97add7c 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev marked this pull request as ready for review November 5, 2023 21:11
@anmyachev
Merge branch 'master' of https://github.com/modin-project/modin into …
8728894 
…issue6708
@anmyachev
fixes
4bdaa49 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
Copy link
Collaborator Author

@YarShev @dchigarev ready for review

YarShev
YarShev reviewed Jan 17, 2024
View reviewed changes
modin/conftest.py Outdated Show resolved Hide resolved
anmyachev
anmyachev commented Jan 17, 2024
View reviewed changes
modin/conftest.py Outdated Show resolved Hide resolved
modin/conftest.py Outdated Show resolved Hide resolved
modin/conftest.py Outdated Show resolved Hide resolved
modin/conftest.py Outdated Show resolved Hide resolved
anmyachev
anmyachev commented Jan 17, 2024
View reviewed changes
modin/conftest.py Outdated Show resolved Hide resolved
@anmyachev @YarShev
Apply suggestions from code review
27cc10e 
Co-authored-by: Iaroslav Igoshev <Poolliver868@mail.ru>
@YarShev YarShev merged commit 602f866 into modin-project:master Jan 17, 2024
37 checks passed
@anmyachev anmyachev deleted the issue6708 branch January 17, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create test files using tmp_path fixture
2 participants
@anmyachev @YarShev