Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST-#6777: Make to_csv tests on Unidist more stable #6776

Merged
merged 13 commits into from
Nov 29, 2023

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Nov 28, 2023

What do these changes do?

to_csv tests for Modin on MPI through unidist component hang sporadically so this PR make tests rerun to avoid sporadic failures due to timeout.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Make to_csv tests on Unidist more stable #6777
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
This reverts commit 3e21940.
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev changed the title TEST-#0000: try to retry hanging to_csv tests TEST-#6777: Make to_csv tests on Unidist more stable Nov 28, 2023
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
This reverts commit 58df526.
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev force-pushed the pytest-plugins branch 4 times, most recently from 918dfbd to 962c86d Compare November 28, 2023 19:18
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
This reverts commit 26f9365.
with:
timeout_minutes: 15
max_attempts: 3
command: conda run --no-capture-output -n modin_on_unidist ${{ matrix.execution.shell-ex }} -m "not exclude_in_sanity" modin/pandas/test/test_io.py --verbose
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use conda run because when using nick-fields/retry@v2 action, the shell that runs the tests is not defined like ours.

YarShev
YarShev previously approved these changes Nov 29, 2023
Copy link
Collaborator

@YarShev YarShev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me!

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@YarShev YarShev merged commit 76d741b into modin-project:master Nov 29, 2023
33 checks passed
@anmyachev anmyachev deleted the pytest-plugins branch November 29, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make to_csv tests on Unidist more stable
2 participants