-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST-#6777: Make to_csv
tests on Unidist more stable
#6776
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmyachev
force-pushed
the
pytest-plugins
branch
from
November 28, 2023 16:16
3e21940
to
91ccec1
Compare
anmyachev
changed the title
TEST-#0000: try to retry hanging
TEST-#6777: Make Nov 28, 2023
to_csv
teststo_csv
tests on Unidist more stable
This reverts commit 58df526.
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
force-pushed
the
pytest-plugins
branch
4 times, most recently
from
November 28, 2023 19:18
918dfbd
to
962c86d
Compare
anmyachev
force-pushed
the
pytest-plugins
branch
from
November 28, 2023 19:31
962c86d
to
b98510d
Compare
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
This reverts commit 26f9365.
anmyachev
commented
Nov 28, 2023
with: | ||
timeout_minutes: 15 | ||
max_attempts: 3 | ||
command: conda run --no-capture-output -n modin_on_unidist ${{ matrix.execution.shell-ex }} -m "not exclude_in_sanity" modin/pandas/test/test_io.py --verbose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to use conda run
because when using nick-fields/retry@v2
action, the shell that runs the tests is not defined like ours.
anmyachev
requested review from
devin-petersohn,
mvashishtha,
RehanSD,
YarShev,
vnlitvinov,
dchigarev and
a team
as code owners
November 28, 2023 21:43
7 tasks
YarShev
previously approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me!
YarShev
reviewed
Nov 29, 2023
anmyachev
commented
Nov 29, 2023
YarShev
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
to_csv
tests for Modin on MPI through unidist component hang sporadically so this PR make tests rerun to avoid sporadic failures due to timeout.flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
to_csv
tests on Unidist more stable #6777docs/development/architecture.rst
is up-to-date