Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR-#6845: Fix import issues found by CodeQL #6837

Merged
merged 2 commits into from Jan 10, 2024
Merged

REFACTOR-#6845: Fix import issues found by CodeQL #6837

merged 2 commits into from Jan 10, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Dec 21, 2023 •
edited

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Fix import issues found by CodeQL #6845
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev anmyachev changed the title REFACTOR-#0000: fix import issues found by CodeQL REFACTOR-#6845: Fix import issues found by CodeQL Jan 4, 2024
@anmyachev anmyachev marked this pull request as ready for review January 4, 2024 17:34
@anmyachev
REFACTOR-modin-project#6845: Fix import issues found by CodeQL
59b86a4 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
address review comments
9f2ee16 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@YarShev YarShev merged commit 5c15c48 into modin-project:master Jan 10, 2024
38 checks passed
@anmyachev anmyachev deleted the cleanup-codeql branch January 10, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

@aregm aregm Awaiting requested review from aregm aregm is a code owner

@gshimansky gshimansky Awaiting requested review from gshimansky gshimansky is a code owner

@ienkovich ienkovich Awaiting requested review from ienkovich ienkovich is a code owner

@Garra1980 Garra1980 Awaiting requested review from Garra1980 Garra1980 is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

@AndreyPavlenko AndreyPavlenko Awaiting requested review from AndreyPavlenko AndreyPavlenko is a code owner

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix import issues found by CodeQL
2 participants
@anmyachev @YarShev