Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#6840: Call tolist function in DtypesDescriptor._merge_dtypes #6844

Merged
merged 1 commit into from Jan 8, 2024
Merged

FIX-#6840: Call tolist function in DtypesDescriptor._merge_dtypes #6844

merged 1 commit into from Jan 8, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Jan 2, 2024 •
edited

What do these changes do?

Fixes a problematic case for the user, but we will also need to fix ModinDtypes.set_index function. This is more complicated, I leave this for @dchigarev.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: Using Concat to Merge Two GroupBy DataFrames #6840
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
FIX-modin-project#6840: Call 'tolist' function in 'DtypesDescriptor._…
1c0e331 
…merge_dtypes'

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev marked this pull request as ready for review January 2, 2024 16:18
@YarShev YarShev merged commit e9cdbaa into modin-project:master Jan 8, 2024
37 of 38 checks passed
@anmyachev anmyachev deleted the issue6840 branch January 8, 2024 13:28
anmyachev added a commit that referenced this pull request Jan 19, 2024
@anmyachev
FIX-#6840: Call 'tolist' function in 'DtypesDescriptor._merge_dtypes' (…
177fc13 
…#6844)

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Using Concat to Merge Two GroupBy DataFrames
2 participants
@anmyachev @YarShev