Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR-#6812: Remove 'PyarrowOnRay' execution in favour of pyarrow-backed pandas dataframes #6848

Merged
merged 2 commits into from Jan 10, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Jan 10, 2024

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Consider to remove experimental PyarrowOnRay execution #6812
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

…r of pyarrow-backed pandas dataframes

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@YarShev
Copy link
Collaborator

YarShev commented Jan 10, 2024

There are references to pyarrow.gandiva in the code in doc_checker and docs/conf.py. Should we remove it too?

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
Copy link
Collaborator Author

There are references to pyarrow.gandiva in the code in doc_checker and docs/conf.py. Should we remove it too?

I removed it, except for troubleshooting section, since users can still use pyarrow.gandiva with Modin on HDK.

@anmyachev anmyachev marked this pull request as ready for review January 10, 2024 11:56
@YarShev YarShev merged commit 31f8bd0 into modin-project:master Jan 10, 2024
53 checks passed
@anmyachev anmyachev deleted the issue6812 branch January 10, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider to remove experimental PyarrowOnRay execution
2 participants