Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST-#6885: Switch to black>=24.1.0 #6887

Merged
merged 3 commits into from Jan 26, 2024
Merged

TEST-#6885: Switch to black>=24.1.0 #6887

merged 3 commits into from Jan 26, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Jan 26, 2024 •
edited

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves CI is broken due to new black=24.1.0 release #6885
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
TEST-modin-project#6885: Switch to black>=24.1.0
4ecd4b1 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 26, 2024
View reviewed changes
scripts/doc_checker.py Fixed Show fixed Hide fixed
@anmyachev
add missed pin
a734bff 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
fix flake8
02b5edf 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev marked this pull request as ready for review January 26, 2024 14:29
YarShev
YarShev previously approved these changes Jan 26, 2024
View reviewed changes
@YarShev
Copy link
Collaborator

YarShev commented Jan 26, 2024

@anmyachev, hdk job failed.

@anmyachev
Copy link
Collaborator Author

@anmyachev, hdk job failed.

Intermittent problem with the order of values, will need to restart.

@anmyachev anmyachev mentioned this pull request Jan 26, 2024
Merged
7 tasks
@YarShev YarShev merged commit 128b286 into modin-project:master Jan 26, 2024
53 checks passed
@anmyachev anmyachev deleted the issue6885 branch January 26, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

@aregm aregm Awaiting requested review from aregm aregm is a code owner

@gshimansky gshimansky Awaiting requested review from gshimansky gshimansky is a code owner

@ienkovich ienkovich Awaiting requested review from ienkovich ienkovich is a code owner

@Garra1980 Garra1980 Awaiting requested review from Garra1980 Garra1980 is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

@AndreyPavlenko AndreyPavlenko Awaiting requested review from AndreyPavlenko AndreyPavlenko is a code owner

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI is broken due to new black=24.1.0 release
2 participants
@anmyachev @YarShev