Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#2405: Make sure named aggregation work for Series objects #6892

Merged
merged 5 commits into from Jan 30, 2024
Merged

FIX-#2405: Make sure named aggregation work for Series objects #6892

merged 5 commits into from Jan 30, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Jan 26, 2024 •
edited

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Named aggregation doesn't work with Series objects #2405
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 26, 2024
View reviewed changes
modin/pandas/base.py Fixed Show fixed Hide fixed
@anmyachev
FIX-modin-project#2405: Make sure named aggregation work for Series o…
f8eaf90 
…bjects

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev force-pushed the issue2405 branch 2 times, most recently from f75c108 to 76edff1 Compare January 29, 2024 19:51
@anmyachev
fixes
182be0f 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev marked this pull request as ready for review January 29, 2024 20:56
@anmyachev
Copy link
Collaborator Author

@dchigarev could you take a look?

YarShev
YarShev reviewed Jan 29, 2024
View reviewed changes
modin/pandas/base.py Outdated Show resolved Hide resolved
modin/pandas/groupby.py Outdated Show resolved Hide resolved
modin/pandas/groupby.py Outdated Show resolved Hide resolved
modin/pandas/groupby.py Outdated Show resolved Hide resolved
modin/pandas/test/test_groupby.py Outdated Show resolved Hide resolved
@anmyachev
address review comments
6758d1e 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
Copy link
Collaborator Author

@YarShev all your comments are addressed.

YarShev
YarShev previously approved these changes Jan 30, 2024
View reviewed changes
modin/pandas/groupby.py Outdated Show resolved Hide resolved
modin/pandas/groupby.py Outdated Show resolved Hide resolved
modin/pandas/groupby.py Outdated Show resolved Hide resolved
anmyachev and others added 2 commits January 30, 2024 11:30
@anmyachev @YarShev
Apply suggestions from code review
87d0ee9 
Co-authored-by: Iaroslav Igoshev <Poolliver868@mail.ru>
@anmyachev
fixes
27edb61 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
dchigarev
dchigarev approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@dchigarev dchigarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YarShev YarShev merged commit 93e7aff into modin-project:master Jan 30, 2024
36 checks passed
@anmyachev anmyachev deleted the issue2405 branch January 30, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchigarev dchigarev dchigarev approved these changes

@YarShev YarShev YarShev left review comments

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Named aggregation doesn't work with Series objects
3 participants
@anmyachev @YarShev @dchigarev