Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#5925: Put a sorting-hack into groupby tests to hide #6875 bug #6896

Merged
merged 1 commit into from Jan 30, 2024

Conversation

dchigarev
Copy link
Collaborator

@dchigarev dchigarev commented Jan 30, 2024

What do these changes do?

CI on master started to fail after #6862 was merged (https://github.com/modin-project/modin/actions/runs/7701338108/job/20995335180). The tests are failing because the order of rows doesn't match between modin and pandas. The test fails even if I won't cast the data to categoricals, so I'm blaming #6875 for the failures. The failure isn't stable (fails not always), that's why it wasn't caught before merging #6862.

My current plan is:

  1. Merge this hack in order to unblock CI
  2. Make the investigation of BUG: groupby(sort=True) may produce unsorted results with range-partitioning implementation #6875 my first priority
  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Reshuffling groupby doesn't handle grouping on a categorical column correctly #5925
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

…odin-project#6875 bug

Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev dchigarev marked this pull request as ready for review January 30, 2024 12:48
@anmyachev anmyachev merged commit c130e13 into modin-project:master Jan 30, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reshuffling groupby doesn't handle grouping on a categorical column correctly
2 participants