Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR-#6293: Corrected 'missmatch' to 'mismatch' across instances of ErrorMessage.missmatch_with_pandas method #6901

Merged

Conversation

Vedant2100
Copy link
Contributor

@Vedant2100 Vedant2100 commented Feb 1, 2024

What do these changes do?

Refactored code in response to issue #6293, addressing a typographical error. I corrected 'missmatch' to 'mismatch' across instances of ErrorMessage.missmatch_with_pandas method as well as in some comments.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves #REFACTOR: Corrected 'missmatch' to 'mismatch' in ErrorMessage.m… #6293
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

…rrorMessage.missmatch_with_pandas method

Signed-off-by: Vedant <2711vedant@gmail.com>
@Vedant2100 Vedant2100 changed the title REFACTOR-#6293: Corrected 'missmatch' to 'mismatch' across instances of ErrorMessage.miss_match_with_pandas method REFACTOR-#6293: Corrected 'missmatch' to 'mismatch' across instances of ErrorMessage.missmatch_with_pandas method Feb 1, 2024
@Vedant2100 Vedant2100 changed the title REFACTOR-#6293: Corrected 'missmatch' to 'mismatch' across instances of ErrorMessage.missmatch_with_pandas method REFACTOR-#6293: Corrected 'missmatch' to 'mismatch' across instances of ErrorMessage.missmatch_with_pandas method Feb 1, 2024
@Vedant2100 Vedant2100 changed the title REFACTOR-#6293: Corrected 'missmatch' to 'mismatch' across instances of ErrorMessage.missmatch_with_pandas method REFACTOR-#6293: Corrected 'missmatch' to 'mismatch' across instances of ErrorMessage.missmatch_with_pandas method Misspell in the method's name: ErrorMessage.missmatch_with_pandas Feb 1, 2024
@Vedant2100 Vedant2100 changed the title REFACTOR-#6293: Corrected 'missmatch' to 'mismatch' across instances of ErrorMessage.missmatch_with_pandas method Misspell in the method's name: ErrorMessage.missmatch_with_pandas REFACTOR-#6293: Corrected 'missmatch' to 'mismatch' across instances of ErrorMessage.missmatch_with_pandas method Misspell in the method's name: ErrorMessage.missmatch_with_pandas Feb 1, 2024
@Vedant2100 Vedant2100 changed the title REFACTOR-#6293: Corrected 'missmatch' to 'mismatch' across instances of ErrorMessage.missmatch_with_pandas method Misspell in the method's name: ErrorMessage.missmatch_with_pandas REFACTOR-#6293: Corrected 'missmatch' to 'mismatch' across instances of ErrorMessage.missmatch_with_pandas method Feb 1, 2024
Copy link
Collaborator

@YarShev YarShev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @Vedant222!

@YarShev YarShev merged commit 4a32e71 into modin-project:master Feb 1, 2024
36 checks passed
@Vedant2100 Vedant2100 deleted the Vedant222/missmatch-type-fix branch February 15, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants