Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#6906: Update to pandas 2.2.* #6907
FEAT-#6906: Update to pandas 2.2.* #6907
Changes from 22 commits
aa7a089
3e95214
50aafd0
7ddbdbc
89ce352
b70c476
45be9fe
ad04596
6c93e94
d5acc78
dbb492e
a06d765
8926eeb
2b0fef5
989f5ec
6ff5749
50caeb4
e7b28b7
0d61497
c766f69
1a5c612
0f44d56
710b2ef
361d7fa
5587af5
045d4bd
adfa204
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't we leave the previous code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lib.no_default
is equivalent forFalse
valueThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably mean the opposite. I see, we can leave the new change as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although, maybe we should make this condition (and all related ones) more explicit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me clarify.
lib.no_default
is equivalent for True value in if condition, but in pandas, for particular method it's equivalent for False value.It seems to me that this is an additional burden on the reader of the code.
Check warning on line 1113 in modin/pandas/base.py
Codecov / codecov/patch
modin/pandas/base.py#L1113
Check warning on line 1621 in modin/pandas/base.py
Codecov / codecov/patch
modin/pandas/base.py#L1621