-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#6906: Update to pandas 2.2.* #6907
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
aa7a089
FEAT-#6906: Update to pandas 2.2.*
anmyachev 3e95214
fix for 'eval'
anmyachev 50aafd0
don't use deprecated offset values
anmyachev 7ddbdbc
fix concat
anmyachev 89ce352
fix groupby tests
anmyachev b70c476
fix API
anmyachev 45be9fe
fix groupby tests for BaseOnPython
anmyachev ad04596
fix concat
anmyachev 6c93e94
Revert "fix concat"
anmyachev d5acc78
fix
anmyachev dbb492e
fix IO functions
anmyachev a06d765
align dependencies with pandas
anmyachev 8926eeb
update sqlalchemy code for new supported versions
anmyachev 2b0fef5
REVERT ME; don't install fuzzydata
anmyachev 989f5ec
FIX ME: skip test__reduce__ for Dask
anmyachev 6ff5749
fix hdk tests
anmyachev 50caeb4
add new functionality for Series
anmyachev e7b28b7
API fixes
anmyachev 0d61497
fix hdk test
anmyachev c766f69
add test for 'case_when'
anmyachev 1a5c612
fix __reduce__ for Dask
anmyachev 0f44d56
address review comments
anmyachev 710b2ef
Revert "REVERT ME; don't install fuzzydata"
anmyachev 361d7fa
add tests for 'limit_area'
anmyachev 5587af5
update fuzzydata version
anmyachev 045d4bd
fixes
anmyachev adfa204
defaults to pandas on query compiler level
anmyachev File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
examples/tutorial/jupyter/execution/pandas_on_dask/requirements.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
fsspec>=2022.05.0 | ||
fsspec>=2022.11.0 | ||
jupyterlab | ||
ipywidgets | ||
modin[dask] | ||
|
2 changes: 1 addition & 1 deletion
2
examples/tutorial/jupyter/execution/pandas_on_ray/requirements.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
fsspec>=2022.05.0 | ||
fsspec>=2022.11.0 | ||
jupyterlab | ||
ipywidgets | ||
tqdm>=4.60.0 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
# Licensed to Modin Development Team under one or more contributor license agreements. | ||
# See the NOTICE file distributed with this work for additional information regarding | ||
# copyright ownership. The Modin Development Team licenses this file to you under the | ||
# Apache License, Version 2.0 (the "License"); you may not use this file except in | ||
# compliance with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software distributed under | ||
# the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF | ||
# ANY KIND, either express or implied. See the License for the specific language | ||
# governing permissions and limitations under the License. | ||
|
||
"""Module houses default applied-on-list accessor functions builder class.""" | ||
|
||
from .series import SeriesDefault | ||
|
||
|
||
class ListDefault(SeriesDefault): | ||
"""Builder for default-to-pandas methods which is executed under list accessor.""" | ||
|
||
@classmethod | ||
def frame_wrapper(cls, df): | ||
""" | ||
Get list accessor of the passed frame. | ||
|
||
Parameters | ||
---------- | ||
df : pandas.DataFrame | ||
|
||
Returns | ||
------- | ||
pandas.core.arrays.arrow.ListAccessor | ||
""" | ||
return df.squeeze(axis=1).list |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
# Licensed to Modin Development Team under one or more contributor license agreements. | ||
# See the NOTICE file distributed with this work for additional information regarding | ||
# copyright ownership. The Modin Development Team licenses this file to you under the | ||
# Apache License, Version 2.0 (the "License"); you may not use this file except in | ||
# compliance with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software distributed under | ||
# the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF | ||
# ANY KIND, either express or implied. See the License for the specific language | ||
# governing permissions and limitations under the License. | ||
|
||
"""Module houses default applied-on-struct accessor functions builder class.""" | ||
|
||
from .series import SeriesDefault | ||
|
||
|
||
class StructDefault(SeriesDefault): | ||
"""Builder for default-to-pandas methods which is executed under struct accessor.""" | ||
|
||
@classmethod | ||
def frame_wrapper(cls, df): | ||
""" | ||
Get struct accessor of the passed frame. | ||
|
||
Parameters | ||
---------- | ||
df : pandas.DataFrame | ||
|
||
Returns | ||
------- | ||
pandas.core.arrays.arrow.StructAccessor | ||
""" | ||
return df.squeeze(axis=1).struct |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't we leave the previous code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lib.no_default
is equivalent forFalse
valueThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably mean the opposite. I see, we can leave the new change as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although, maybe we should make this condition (and all related ones) more explicit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me clarify.
lib.no_default
is equivalent for True value in if condition, but in pandas, for particular method it's equivalent for False value.It seems to me that this is an additional burden on the reader of the code.